Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: continuous integration #6

Merged
merged 18 commits into from
Sep 28, 2023
Merged

Conversation

dragonmux
Copy link
Member

In preparation for releasing bmpflash and to provide better insights for PRs going forward, this PR introduces a full CI suite for the big three and fixes some issues that fell out from testing.

dragonmux and others added 18 commits September 28, 2023 17:35
While reading the workflow files without previous knowledge the use BUILD_OPTS variable is confusing, it's not clear where it comes from, or if it even is populated, this makes it clear it is just a statically empty variable for now, and can be populated if needed in the future
@dragonmux dragonmux added Enhancement General project improvement CI Continuous Integration System Core: Build system Something related to the build system labels Sep 28, 2023
@dragonmux dragonmux added this to the v1.0 milestone Sep 28, 2023
@dragonmux dragonmux requested a review from esden September 28, 2023 16:54
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@9c73825). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             main      #6   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?      30           
  Lines           ?    1560           
  Branches        ?     491           
======================================
  Hits            ?       0           
  Misses          ?    1522           
  Partials        ?      38           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esden esden merged commit 6710bc4 into main Sep 28, 2023
34 checks passed
@dragonmux dragonmux deleted the feature/continuous-integration branch September 28, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration System Core: Build system Something related to the build system Enhancement General project improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants