Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to hide UI #70

Merged
merged 7 commits into from
Dec 31, 2022
Merged

Option to hide UI #70

merged 7 commits into from
Dec 31, 2022

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Nov 6, 2022

This is still not in a finished state, but it works, so I thought I'd share. I also mentioned this in #63 (comment).

To use, try starting hwatch with the new -t argument. Additionally, try the Backspace and t keybindings inside hwatch. (I keep meaning to change these, but haven't decided what to change them to).

Fixes #63

@blacknon
Copy link
Owner

blacknon commented Nov 6, 2022

Oh, I confirmed that it works!
It is wonderful!

I would like to apply it in version 0.3.8.

@blacknon
Copy link
Owner

blacknon commented Dec 8, 2022

@ilyagr
I would like to remove this pull request draft and merge it, is that ok?

@ilyagr
Copy link
Contributor Author

ilyagr commented Dec 8, 2022 via email

@ilyagr ilyagr marked this pull request as ready for review December 11, 2022 05:32
@ilyagr ilyagr changed the base branch from master to 0.3.8 December 11, 2022 05:33
@ilyagr
Copy link
Contributor Author

ilyagr commented Dec 11, 2022

OK, I think I did what I wanted. The toggle for the UI is now t, to match the -t option. I also added the help messages.

@ilyagr ilyagr force-pushed the hideui branch 3 times, most recently from c44dfc8 to 142de41 Compare December 11, 2022 06:52
@ilyagr
Copy link
Contributor Author

ilyagr commented Dec 11, 2022

This now includes #75.

@ilyagr ilyagr force-pushed the hideui branch 2 times, most recently from 1a98c90 to 3536a93 Compare December 11, 2022 07:45
Copy link
Owner

@blacknon blacknon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!!! That is fantastic!
We have checked the operation and reviewed the code. I'm going to merge it into 0.3.8.

@blacknon blacknon merged commit c697fc0 into blacknon:0.3.8 Dec 31, 2022
@ilyagr
Copy link
Contributor Author

ilyagr commented Jan 1, 2023

Thanks for taking a look and merging all my PRs! They help me a lot, hopefully they'll be useful for others as well.

@ilyagr
Copy link
Contributor Author

ilyagr commented Jan 1, 2023

Also, if you celebrate it, Happy New Year! 🎆 🎉

@blacknon blacknon added this to the 0.3.8 milestone Jan 4, 2023
@blacknon blacknon mentioned this pull request Jan 4, 2023
blacknon added a commit that referenced this pull request Jan 4, 2023
Version 0.3.8.

- Added a function to notify with a beep sound when updating result(add `-B` option) #22
- Added a function to execute the specified command when there is a change in the command output result(add `-A "command..."` option)
- Added a function to switch to display only lines with differences by <kbd>Shift</kbd> + <kbd>O</kbd> when line/word diff.
- Added option to hide header and history window(add `-t` option and <kbd>T</kbd> and <kbd>Backspace</kbd> key) #70 
- Added an option to hide the message "Display help with h key" (add `--no-help-banner` option) #76 
- Added a function that can be set by writing options in the environment variable "HWATCH" #76
- Mouse wheel support(add `--mouse` option) #77 
- Changed to restore the terminal cleanly when killed #78 
- Debug hwatch_log #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants