fix: use of @optional directive in protocols and interfaces #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@optional
directive of Objective-C defines that all property and method definitions bellow it are optional. This only changes if a@required
directive is placed bellow it. go-macho doesn't implement this properly and mistakenly declares required methods as optional.Additionally,
@required
and@optional
should only ever be used inside@protocol
blocks. But go-macho also uses them in@interface
blocks.This patch fixes both issues.
As I have tweaked the formatting of generated code slightly, I also changed the formatting of categories to keep consistency.
Before:
After: