-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inactivity timeout option #37
Add inactivity timeout option #37
Conversation
Do you have an idea, how to display the tooltips in a better way? The title tag was a small workaround for my option field, but I think it isn't nice. |
If you add something with a class of By the way, do you know how to mark the variable |
Have a look at the line 100 Maybe you could implement it like that, so the code will not crash, if pwl is not defined. I think, codacy will then stop yelling about it. |
I think, we shoul think about the solution with the |
I updated the screenshot with the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
wp_localize_script( 'post-worktime-logger', 'pwl', | ||
array( 'ajax_url' => admin_url( 'admin-ajax.php' ) ) | ||
); | ||
$pwt_options = get_option("post-worktime-logger-options"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already loaded the options, you can use $pwlOptions
@blackus3r updated to use existing options. |
Nice work 👍 Thank you |
Resolves #34
Screenshot:
