Remove labelled-by attribute from SVG when title attribute is passed #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@driesvints I discussed this with my team this morning and it looks like the easy solution would be to remove aria-labelledby attribute from SVG's.
This follows the 5th pattern in Deque best practices, which has similar support to pattern 8, which we were using earlier.
So, this:
will result in this:
Let me know what you think!
Aarish
closes #248