Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove labelled-by attribute from SVG when title attribute is passed #249

Merged
merged 15 commits into from
Aug 14, 2024

Conversation

aarishgilani
Copy link
Contributor

@driesvints I discussed this with my team this morning and it looks like the easy solution would be to remove aria-labelledby attribute from SVG's.

This follows the 5th pattern in Deque best practices, which has similar support to pattern 8, which we were using earlier.

So, this:

<x-icon-solid.camera title="camera" />

will result in this:

<svg class="svg-inline--fa fa-arrow-right" role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 448 512">

<title>camera</title>

<path fill="currentColor" d="M438.6 278.6c12.5-12.5 12.5-32.8 0-45.3l-160-160c-12.5-12.5-32.8-12.5-45.3 0s-12.5 32.8 0 45.3L338.8 224 32 224c-17.7 0-32 14.3-32 32s14.3 32 32 32l306.7 0L233.4 393.4c-12.5 12.5-12.5 32.8 0 45.3s32.8 12.5 45.3 0l160-160z"></path>

</svg>

Let me know what you think!

Aarish

closes #248

@driesvints driesvints merged commit 8f787ba into blade-ui-kit:1.x Aug 14, 2024
13 checks passed
@driesvints
Copy link
Member

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

v1.7.0 introduced blade cache issues
3 participants