Nest grids. Produce PDF manual. #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @blakeNaccarato - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -6,7 +6,15 @@ For more detail, see the manual in the black binder in {numref}`00-01-ref`, the | |||
|
|
|||
| First, turn on the instrument by pressing the power button indicated in {numref}`00-04-turn-on`, and the laptop associated with this instrument in {numref}`00-18-laptop`. Note that the language bar in {numref}`00-05-language` may need to be set to "English (United States)" if it is not set already. Open the software by clicking on the icon indicated in {numref}`00-06-desktop-software-indicated`, and you will be prompted with the login dialog in {numref}`00-07-login`. Just click "OK" to proceed. The instrument should be left to warm up for about thirty minutes before testing. | |||
|
|
|||
| ::::{grid} 1 1 2 2 | |||
| :::::::{grid} 12 | |||
There was a problem hiding this comment.
suggestion (code_refinement): Consider simplifying the grid layout for better readability and maintenance.
Using a simpler grid structure might make the document easier to maintain and modify in the future, especially if the layout or content changes.
Suggested change
| :::::::{grid} 12 | |
| :::::::{grid} 1 |
| @@ -152,6 +192,14 @@ You don't need to select a "Material Lot" for the Pyrex reference sample. | |||
|
|
|||
| Proceed to [](#checking-on-a-test-run) to monitor the test for the first few measurements, after which you can leave it unattended. | |||
|
|
|||
| ::::::::{grid} 12 | |||
There was a problem hiding this comment.
suggestion (code_refinement): Assess if the additional complexity of the grid layout is justified by the content requirements.
The added complexity of the grid layout should be justified by specific content presentation requirements. If not, a simpler layout might be more effective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and context
Test plan
Checklist
Terms