Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runPubGetOnPubspecChanges implementation is outdated #37

Closed
vkammerer opened this issue Sep 14, 2022 · 1 comment · Fixed by #38
Closed

runPubGetOnPubspecChanges implementation is outdated #37

vkammerer opened this issue Sep 14, 2022 · 1 comment · Fixed by #38
Labels
bug Something isn't working

Comments

@vkammerer
Copy link

In order to address Dart-Code/Dart-Code#4110, runPubGetOnPubspecChanges was changed from a boolean to a always/prompt/never enum.
Dart-Code/Dart-Code@029850e is already merged and deployed to VSCode end users.

It means that the setting generated by this extension is now flagged by the linter:
Screen Shot 2022-09-14 at 2 44 30 PM
@blaugold
Copy link
Owner

Thanks for reporting this.

@blaugold blaugold added the bug Something isn't working label Sep 15, 2022
blaugold added a commit that referenced this issue Sep 15, 2022
@blaugold
feat: don't touch dart.runPubGetOnPubspecChanges when `usePubspecOv…
0a8d477 
…errides` is enabled

Also uses the new format for `dart.runPubGetOnPubspecChanges`.

Fixes #36
Fixes #37
@blaugold blaugold mentioned this issue Sep 15, 2022
Merged
blaugold added a commit that referenced this issue Sep 15, 2022
@blaugold
feat: don't touch dart.runPubGetOnPubspecChanges when `usePubspecOv…
da73508 
…errides` is enabled (#38)

Also uses the new format for `dart.runPubGetOnPubspecChanges`.

Fixes #36
Fixes #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@vkammerer @blaugold