Added a method of read the colour of any pixel #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added method to read back the RGB colour of any pixel
I realised I had lost changes made to the library I forked from, so restored these and added rgbw support to my get pixel colour method (untested as I don't have a suitable LED device to hand).
blaz-r
reviewed
Nov 11, 2022
blaz-r
reviewed
Nov 11, 2022
blaz-r
reviewed
Nov 11, 2022
blaz-r
reviewed
Nov 11, 2022
blaz-r
requested changes
Nov 11, 2022
There was a problem hiding this comment.
Thanks for this contribution :). There are some things that need to be addressed. I commented all of them in this review and gave some suggestions.
I didn't test it on Pico as I don't currently have access to it, but once this is all resolved I'll test that and merge if everything works.
blaz-r
added
enhancement
|
Updated with suggested changes, and also now tested against some real RGBW LEDs. |
|
Thanks for this addition and all corrections. I'll now merge and write documentation for this function in wiki |
blaz-r
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to read pixel values for an application, so I added this method to get back the RGB values of any LED. I tried to write it to also support RGBW mode, but I have not been able to test if this works as I do not have that type of LED to hand.