Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support list of dedicated resolvers/nameservers in domains file #116

Conversation

infosec-it-init
Copy link
Contributor

See #49
I finally got some time to implement it with buffer_t struct for the resolvers per entry.
As I have very limited experience with coding C, it would be good to do a proper review of the code :-)

Also, you might want to add a command line option to enable this feature?

@blechschmidt blechschmidt merged commit f18a462 into blechschmidt:master Sep 1, 2021
@blechschmidt
Copy link
Owner

Thank you for contributing and apologies for the late reply. I have added the --extended-input command line option to enable this feature.

I have made some changes to the code as I want to keep the number of allocations quite small (when the resolving process has begun at least). In particular, I have removed any heap allocation that does not directly contribute to adding the resolvers to the lookup instance. For example, instead of making a copy of the line buffer in order to split it, strtok is used. Since we don't reuse the buffer anyway, there is no need to make a full copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants