Add ability to set insecure via environment variable #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running a [custom container service] via cephadm it is not possible to set any arguments for the container entrypoint. You can only set arguments for the docker/podman command itself and set environment variables. This works well with `RADOSGW_SERVER`, etc. but does not allow for the usage of private certificates on the RGW endpoint when using the exporter this way. This commit adds the option to set `SECURE=false` to ignore certificate errors (which I need – unfortunately). This also adjusts the arguments name to use "secure" as a name to make the code more readable. [custom container service]: https://docs.ceph.com/en/quincy/cephadm/services/custom-container/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a custom container service via cephadm it is not possible to set any arguments for the container entrypoint. You can only set arguments for the docker/podman command itself and set environment variables. This works well with
RADOSGW_SERVER, etc. but does not allow for the usage of private certificates on the RGW endpoint when using the exporter this way.This commit adds the option to set
SECURE=falseto ignore certificate errors (which I need – unfortunately).This also adjusts the arguments name to use "secure" as a name to make the code more readable.