Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error reporting details to stderr #15

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Conversation

JeanMertz
Copy link
Contributor

@JeanMertz JeanMertz commented Feb 22, 2018

Minor improvement when debugging templating errors. The output now prints the final compiled charts.yml, including line numbers, and highlights the problematic area:

screen shot 2018-02-22 at 21 23 33

Note: in the above case, the problem is actually two lines above the red one, but we can only relay what the YAML parser tells us, and even though the problem originates two lines higher, the actual parsing error comes from the red line, nothing we can do there, except use some common sense to see what's really the cause (also, that's where the extra context helps out)

Copy link

@niels-s niels-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik

@JeanMertz JeanMertz changed the base branch from partials to master February 23, 2018 14:49
@JeanMertz JeanMertz merged commit 9408029 into master Feb 23, 2018
@JeanMertz JeanMertz deleted the better-errros branch February 23, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants