MB-58901: BM25 related constructs and API changes #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thejas-bhat
changed the title
Thejas-bhat
requested review from
abhinavdangeti,
metonymic-smokey,
CascadingRadium and
Likith101
indexing_options.go
Outdated
| const DefaultSimilarityModel = BM25Similarity | ||
|
|
||
| // Supported similarity models | ||
| var SupportedSimilarityModels = map[string]struct{}{ |
There was a problem hiding this comment.
Let's call this SupportedScoringModels or algorithms perhaps.
indexing_options.go
Outdated
| @@ -24,6 +24,23 @@ const ( | |||
| SkipFreqNorm | |||
| ) | |||
|
|
|||
| const ( | |||
| BM25Similarity = "bm25" | |||
There was a problem hiding this comment.
Replace Similarity with Scoring here and below.
indexing_options.go
Outdated
| // similarity model just means the scoring mechanism used to rank documents fetched | ||
| // for a query performed on a field. Default is the bm25 scoring but can be set | ||
| // to other models like the legacy tf-idf. | ||
| const DefaultSimilarityModel = BM25Similarity |
There was a problem hiding this comment.
Default to TfIdfScoring ?
abhinavdangeti
previously approved these changes
Jan 7, 2025
abhinavdangeti
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.