Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage #10

Open
lightning-auriga opened this issue Mar 12, 2022 · 1 comment
Open

Test coverage #10

lightning-auriga opened this issue Mar 12, 2022 · 1 comment

Comments

@lightning-auriga
Copy link

the test coverage from covr is ~71% but it seems like the coverage is somewhat more accurately ~4%. tests/testthat/test_CVtreeMLE_breastcancer.R runs an example but doesn't include any assertions and doesn't inspect the output of the run (and in fact emits a warning on my system. due to how the test files are structured, the only function that seems to have substantial coverage right now is simulate_mixture_cube.

with the above, I find it very challenging to evaluate the functionality of the software. please expand the test coverage as necessary to ensure the majority of the functions are running not just end to end, but as expected when run.

@blind-contours
Copy link
Owner

I have included examples in the documentation that run an example of each major function. I've added and am still adding more testing. With the breast cancer test, our goal is to ensure that the output interactions are in the correct format - I've updated this test script accordingly. Other tests have been included to ensure we are getting, for a respective variable set, the rules that have the maximum explanatory on the outcome in the iterative backfitting procedure. I'm adding some additional tests for the estimators as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants