Sort imports with Isort.

[TheQuinbox]

Link to issue number:

None

Summary of the issue:

In Pep-8, it's convention to sort imports a certain way. There's a tool (Isort) that does this for us.

Description of how this pull request fixes the issue:

Added Isort to requirements-dev, and ran it on the entire codebase.

Testing performed:

None necessary (Isort doesn't change functionality), similar to Black.

Known issues with pull request:

None

[mush42]

Hi @TheQuinbox

I tried isort last week and after running it on the source code bookworm failed to run.

We've some problems with circular imports, unless we fix those, the tool will, actually, effect the functionality.

I'll be keeping an eye on this PR.

Best

[TheQuinbox]

@mush42, I don't actually see how that's possible. AFAIK, Isort just moves code around (puts line breaks, indents extra long lines, etc). None of that should cause circular imports.

I would test, but I'm currently unable to run Bookworm from source for... some reason. What files were causing the problem?

[pauliyobo]

Hello.
@TheQuinbox I was able to solve the circular import issues, or at least solve enough to make bookworm run in a test branch.
How would you like to progress on this?

[TheQuinbox]

@pauliyobo, if you could make it run, resolve the merge conflicts and merge it, that would be amazing! :). If not, I can close this, no issue there.

[mush42]

@pauliyobo Is it safe to re-run isort on the code base without reservations?

[pauliyobo]

@mush42 It should be yes.
Although I am personally thinking that we should probably automate this process with something like pre-commit in order to maintain consistency. Would you have any problem with this? I am happy to open an issue if not.

[mush42]

No. I have no problems with adding pre-commit.
Do you have time to add this? Or should I add it myself?

[pauliyobo]

I do. I'll add this tomorrow.