Replace accessible output dependency #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pauliyobo Awesome work! |
|
Hello, @mush42 It's great to see you're active on this project, but please reply here if possible because I haven't received any response via email or TG message. Will you address other issues that are open in the project? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously bookworm used its own fork of accessible-output2. However, this began to cause some problems because of a known long standing bug which would essentially mess with the gempy cache, crashing the application.
The latest version of AO2, which was published to PyPI over a year ago, addresses tihs issue, and this PR replaces our fork with the original version, which should not affect the current code.
Fixes #165