Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSError by replacing os.link with os.symlink for cross-drive compatibility #260

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

cary-rowen
Copy link
Collaborator

Link to issue number:

None

Summary of the issue:

The os.link function was causing an OSError when attempting to create a hard link between different drives, preventing invoke run and invoke bench from executing properly.

Description of how this pull request fixes the issue:

This pull request replaces the os.link function with os.symlink in the bookworm/platforms/win32/speech_engines/piper/__init__.py file. Unlike hard links, symbolic links can span across different drives, resolving the issue and allowing the commands to execute without errors.

Testing performed:

Tested in an environment with the project directory and Python installation on separate drives. Verified that invoke run and invoke bench commands now execute successfully without encountering the OSError.

Known issues with pull request:

None

@cary-rowen cary-rowen merged commit 8d2805d into blindpandas:develop Aug 26, 2024
1 check failed
@cary-rowen cary-rowen deleted the fixOSError branch August 26, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant