Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deadlock in protocol shutdown #478

Closed
agaffney opened this issue Jan 26, 2024 · 0 comments · Fixed by #479
Closed

Deadlock in protocol shutdown #478

agaffney opened this issue Jan 26, 2024 · 0 comments · Fixed by #479

Comments

@agaffney
Copy link
Contributor

When reading from the send queue, we don't also check for doneChan to be closed, which causes a deadlock when the protocol shuts down when there aren't any pending messages.
agaffney added a commit that referenced this issue Jan 26, 2024
@agaffney
fix: protocol shutdown deadlocks
4882e4f 
Fixes #478
agaffney added a commit that referenced this issue Jan 26, 2024
@agaffney
fix: protocol shutdown deadlocks
9c5e339 
Fixes #478
agaffney added a commit that referenced this issue Jan 26, 2024
@agaffney
fix: protocol shutdown deadlocks
5ec9638 
Fixes #478
agaffney added a commit that referenced this issue Jan 26, 2024
@agaffney
fix: protocol shutdown deadlocks
50c3fce 
Fixes #478
@agaffney agaffney mentioned this issue Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: protocol shutdown deadlocks blinklabs-io/gouroboros
1 participant
@agaffney