Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for TX attribute: protocol parameters update #599

Merged
merged 1 commit into from
Apr 29, 2024
Merged

feat: add support for TX attribute: protocol parameters update #599

merged 1 commit into from
Apr 29, 2024

Conversation

verbotenj
Copy link
Contributor

Closes #333

wolf31o2
wolf31o2 requested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the function to the Transaction interface and add it to any remaining TransactionBody types. The computer will let you know if you miss anything once you add it to the interface.

@verbotenj
feat: add support for TX attribute: protocol parameters update
12aed9e 
Signed-off-by: Ales Verbic <verbotenj@blinklabs.io>
@verbotenj verbotenj force-pushed the feat/support-for-tx-protocol-parameter branch from f07c9be to 12aed9e Compare April 27, 2024 14:24
@verbotenj verbotenj merged commit cdfeb4b into main Apr 29, 2024
8 checks passed
@verbotenj verbotenj deleted the feat/support-for-tx-protocol-parameter branch April 29, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf31o2 wolf31o2 wolf31o2 approved these changes

@agaffney agaffney Awaiting requested review from agaffney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for TX attribute: protocol parameter updates
2 participants
@verbotenj @wolf31o2