feat(tests): Added tests for the tfe block #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
marked this pull request as ready for review
kimfy
reviewed
Jan 8, 2024
role_definitions.tf
Outdated
| @@ -3,7 +3,7 @@ resource "azurerm_role_definition" "user_created" { | |||
| role_definition_id = each.value.role_definition_id | |||
| name = each.value.name | |||
| description = each.value.description | |||
| scope = each.value.scope | |||
| scope = each.value.scope == null ? "/subscriptions/${data.azurerm_client_config.current.subscription_id}" : each.value.scope | |||
There was a problem hiding this comment.
I want to discuss if we can set the default scope to the workload's resource group id. Are there any downsides to doing that @SanderBlom?
There was a problem hiding this comment.
It would probably be a better to reduce the scope to the workload resource group. I'll update the PR :)
|
I reached out to Hashicorp about this issue and this was the response I got back: I completely understand your limitation, and we are working on enhancing how variables are done in the test framework. It might not happen asap, might be a few months, but we know this is a problem and intend on building the capability. Please open a github issue and we will prioritize this. We intend on making many more changes to the test framework, so we will work on this for sure. Omar Ismail |
|
I have now opened an issue on this hashicorp/terraform#34534 |
SanderBlom
changed the title
kimfy
changed the title
kimfy
changed the title
SanderBlom
changed the title
SanderBlom
changed the title
SanderBlom
temporarily deployed
to
E2E_testing
GitHub Actions
Inactive
…d run restrictions
SanderBlom
temporarily deployed
to
E2E_testing
GitHub Actions
Inactive
SanderBlom
had a problem deploying
to
E2E_testing
GitHub Actions
Failure
… is automatically validated in terraform 1.6
SanderBlom
temporarily deployed
to
E2E_testing
GitHub Actions
Inactive
SanderBlom
temporarily deployed
to
E2E_testing
GitHub Actions
Inactive
SanderBlom
temporarily deployed
to
E2E_testing
GitHub Actions
Inactive
…between e2e tests
SanderBlom
temporarily deployed
to
E2E_testing
GitHub Actions
Inactive
SanderBlom
temporarily deployed
to
E2E_testing
GitHub Actions
Inactive
SanderBlom
temporarily deployed
to
E2E_testing
GitHub Actions
Inactive
SanderBlom
approved these changes
Feb 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #90.
Whats has changed/added in this PR
workspace_env_varsin the TFE block. When the module was trying to merge the variables for the TFC workspace, it was incorrectly attempting to merge content from an undefined variablevar.tfe.env_vars.testfolder) to start withtest_testsfolder. See new readme on how to run the test