Fix all errors when creating the executable file #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miladsoft
changed the title
sondreb
requested changes
Apr 2, 2022
dev-app-update.yml
Outdated
| @@ -0,0 +1,4 @@ | |||
| owner: block-core | |||
There was a problem hiding this comment.
Remove this file, it should not be included, only used for testing the auto-update feature in development mode.
A comment from electron-userland:
"dev-app-update.yml is only and only for testing during development and unpacked. And it is advanced feature. Consider to test using packed app."
You added this because you get an 404? Instead we should improve the checks in the code.
Consider adding a dependency on this package: https://github.com/sindresorhus/electron-is-dev
Then only running "autoUpdater.checkForUpdates()" in production.
There was a problem hiding this comment.
As others comments: "You should not use electron updater in the dev mode."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.