Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow account restore API to specify if cold staking accounts should be restored #358

Closed
sondreb opened this issue Oct 13, 2021 · 2 comments · Fixed by #359
Closed

Allow account restore API to specify if cold staking accounts should be restored #358

sondreb opened this issue Oct 13, 2021 · 2 comments · Fixed by #359
Assignees
Labels
bug Something isn't working

Comments

@sondreb
Copy link
Member

sondreb commented Oct 13, 2021

Add an option to the recover API like below to allow users to specify if they want to restore the "coldStakingColdAddresses" and "coldStakingHotAddresses" accounts. It will default to false, so it must be explicit be provided for future wallet implementations that relies on the node.

This is done because accounts cannot be removed after created, and they are blocking a restored recovery phrase to enable cold staking (not allowed to activate when both accounts are created on the wallet).

image

@sondreb sondreb added the bug Something isn't working label Oct 13, 2021
@sondreb sondreb self-assigned this Oct 13, 2021
@dangershony
Copy link
Member

Hmm come to think about it you can still create a new wallet on the same node for recovery of coldstaking no?

@sondreb
Copy link
Member Author

sondreb commented Oct 13, 2021

I'm not sure why we have both an create and restore API, when you can supply the recovery phrase (mnemonic) on the create method. You can create a new wallet on the same node, but restoring will restore both coldStakingColdAddresses and coldStakingHotAddresses, which will then disallow activating cold staking later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants