Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an interface to override services from the network class #438

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Add an interface to override services from the network class #438

merged 1 commit into from
Apr 15, 2023

Conversation

dangershony
Copy link
Member

I am not totally sure this is the right location to put the override class, suggestions are welcome.

sondreb
sondreb approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@sondreb sondreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@miladsoft
Copy link
Member

Looks good

@dangershony dangershony merged commit faa5f75 into master Apr 15, 2023
@dangershony dangershony deleted the enable-nodebuilder-services-override branch April 15, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreb sondreb sondreb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dangershony @miladsoft @sondreb