Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for contracts, tokens #11

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Conversation

bsh98
Copy link
Contributor

@bsh98 bsh98 commented Mar 1, 2022

Adds support for exporting contracts and tokens tables.

The relevant streaming changes can be found here blockchain-etl/ethereum-etl#293.

@whydna
Copy link

whydna commented Mar 16, 2022

@bsh98 awesome - does the current version not support contracts? Will this change work seamlessly if I've already run an export against the current version? Any idea when this PR will be ready/merged?

@bsh98
Copy link
Contributor Author

bsh98 commented Apr 1, 2022

@bsh98 awesome - does the current version not support contracts? Will this change work seamlessly if I've already run an export against the current version? Any idea when this PR will be ready/merged?

Thank you! No, the current version does not support contracts. And yes, this should work no problem if you've already run the current version. The PR should be ready, but unfortunately I don't have an estimate on when it will be merged. (It looks like there hasn't been much activity on this repo recently.)

@medvedev1088 medvedev1088 merged commit 91aaa11 into blockchain-etl:master Apr 1, 2022
@medvedev1088
Copy link
Member

Thanks for the PR @bsh98 !

@medvedev1088
Copy link
Member

This index will prevent loading historical contracts since there are contract deployed multiple times in the same block alter table contracts add constraint contracts_pk primary key (address, block_number); as discovered by a user https://t.me/c/1190882423/1504

Eugene Hsu, [24 Apr 2022 at 4:57:18 PM]:
Hello guys

I'm using ethereum-etl-postgres (https://github.com/blockchain-etl/ethereum-etl-postgres) to fetch contracts data, and found there are some duplicate records in the data source, is there anyone encounter the same problem?

data source is: bigquery > bigquery-public-data.crypto_ethereum.contracts

I found a duplicate records through sql below, and there are more records like this:

SELECT * FROM bigquery-public-data.crypto_ethereum.contracts WHERE address = '0x21e89b517469604e7ea9f564c45ef33d512fff9d' AND block_number = 9391097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants