Hotfix: add check to geth traces for missing output
#150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for errors where node response is missing
output
fields. Use similar retry mechanism to existing check for responses with nullresult
.The issue we encountered is probably related to: maticnetwork/bor#763
Also:
test_export_geth_traces.py
mock test dataThe basis for the check is the bad data I found in the
geth_traces_00.json
of a failed run. This source file is now overwritten, but here's the line I cut from it, a single block (which I've then formatted for readability):bad_geth_trace.txt
I've inferred (from export_geth_traces_job.py) that the bad response would have been:
bad_response_full.txt
I noted that traces with returned
error
field do also not haveoutput
, hence why I excluded these, see this genuine RPC response for block_with_error