Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: approve scripts to aid swaps #99

Closed
0xneves opened this issue Nov 10, 2023 · 2 comments
Closed

feat: approve scripts to aid swaps #99

0xneves opened this issue Nov 10, 2023 · 2 comments
Assignees
@blackbeard002
Labels
enhancement New feature or request
Milestone
Swaplace v1.0.0

Comments

@0xneves
Copy link
Contributor

0xneves commented Nov 10, 2023 •
edited
Loading

Proposal:

  • Build approve scripts to use with ERC20 and ERC721
    • must be easy to use and understand
    • must be a script of type export
    • adapted to the current tests where there is approvals
@0xneves 0xneves added enhancement New feature or request good first issue Good for newcomers labels Nov 10, 2023
@0xneves 0xneves added this to the Swaplace v1.0.0 milestone Nov 10, 2023
@0xneves 0xneves added this to Swaplace Nov 10, 2023
@0xneves 0xneves moved this to 🔖 TODO in Swaplace Nov 10, 2023
@0xneves 0xneves mentioned this issue Nov 10, 2023
Closed
@0xneves 0xneves removed the enhancement New feature or request label Nov 10, 2023
@Guboehm
Copy link

Guboehm commented Nov 23, 2023

Hi @0xneves, I'm interested in this task.

blackbeard002 added a commit to blackbeard002/swaplace-contracts that referenced this issue Nov 23, 2023
@blackbeard002
feat: deploy mock contracts blockful-io#100 and feat: approve script…
e16b32d 
…s to aid swaps blockful-io#99
@blackbeard002 blackbeard002 mentioned this issue Nov 23, 2023
Merged
@blackbeard002
Copy link
Contributor

Hey @Guboehm I'm sorry, I had to make a PR for this issue since it was a part of issue #100 . My PR isn't yet reviewed anyways. Just wanted to give you a heads up.

@0xneves 0xneves moved this from 🔖 TODO to 🕵️‍♀️ In Review in Swaplace Nov 27, 2023
0xneves added a commit that referenced this issue Dec 21, 2023
@0xneves
Merge pull request #108 from blackbeard002/deploy
f691528 
Deployed mock contracts #100 and  approve scripts to aid swaps #99
@0xneves 0xneves moved this from 🕵️‍♀️ In Review to ✅ Done in Swaplace Jan 12, 2024
@0xneves 0xneves added enhancement New feature or request and removed good first issue Good for newcomers labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackbeard002 blackbeard002

Labels
enhancement New feature or request
Projects
Swaplace
Status: ✅ Done
Milestone
Swaplace v1.0.0
Development

No branches or pull requests
3 participants
@blackbeard002 @Guboehm @0xneves