Fix issues with JS and Prestashop Vulnerabilities #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sambhav1403
commented
Jul 18, 2023
•
Sambhav1403
commented
- Adds Display Error Support to show incase of rendering issues
- Replaces nofilter prestashop's filter with decodeEscapedHtml to handle decoding on client side js.
Sambhav1403
changed the title
DarrenWestwood
requested changes
Jul 19, 2023
views/templates/front/payment.tpl
Outdated
| var blockonomics_data = JSON.stringify({ | ||
| time_period: {$time_period}, | ||
| crypto: JSON.parse('{json_encode($crypto) nofilter}'), | ||
| crypto: JSON.parse(decodeEscapedHtml('{json_encode($crypto)}')), |
There was a problem hiding this comment.
Using DOMParser works, however it looks like we are avoiding escaping the data. We can use the following in the smarty template:
JSON.parse('{$crypto|@json_encode|escape: 'javascript'}'.replaceAll('"', '"'))
views/templates/front/payment.tpl
Outdated
| @@ -28,6 +28,12 @@ | |||
| <div class="bnomics-spinner"></div> | |||
| </div> | |||
|
|
|||
| <!-- Display Error --> | |||
| <div class="bnomics-display-error"> | |||
| <h2>{l s='Display Error' mod='blockonomics'}{$id_order}</h2> | |||
There was a problem hiding this comment.
We can escape all outputs to avoid security warnings in the prestashop validator
{$id_order|escape:'htmlall'}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.