Smart-contract proxy detection refactoring #8807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbaranov
force-pushed
the
vb-enhance-gnosis-safe-proxy
branch
20 times, most recently
from
db6e3d0 to
1d364fe
Compare
9 tasks
vbaranov
force-pushed
the
vb-enhance-gnosis-safe-proxy
branch
7 times, most recently
from
4a77a03 to
c649899
Compare
vbaranov
force-pushed
the
vb-enhance-gnosis-safe-proxy
branch
2 times, most recently
from
060fb6f to
7026ef9
Compare
sl1depengwyn
requested changes
Nov 13, 2023
apps/explorer/lib/explorer/chain/smart_contract/proxy/eip_1822.ex
Outdated
Show resolved
Hide resolved
apps/explorer/lib/explorer/chain/smart_contract/proxy/eip_1967.ex
Outdated
Show resolved
Hide resolved
apps/explorer/lib/explorer/chain/smart_contract_additional_sources.ex
Outdated
Show resolved
Hide resolved
vbaranov
force-pushed
the
vb-enhance-gnosis-safe-proxy
branch
from
680dbad to
3cca119
Compare
nikitosing
requested changes
Nov 15, 2023
apps/explorer/lib/explorer/chain/smart_contract/proxy/eip_930.ex
Outdated
Show resolved
Hide resolved
apps/explorer/lib/explorer/chain/smart_contract/proxy/eip_1967.ex
Outdated
Show resolved
Hide resolved
apps/explorer/lib/explorer/chain/smart_contract/proxy/eip_1967.ex
Outdated
Show resolved
Hide resolved
apps/explorer/lib/explorer/chain/smart_contract/proxy/master_copy.ex
Outdated
Show resolved
Hide resolved
vbaranov
force-pushed
the
vb-enhance-gnosis-safe-proxy
branch
from
81c9e2b to
d419fd1
Compare
vbaranov
force-pushed
the
vb-enhance-gnosis-safe-proxy
branch
from
62b4e6c to
fff31fe
Compare
nikitosing
force-pushed
the
vb-enhance-gnosis-safe-proxy
branch
from
731e32f to
f8782d0
Compare
nikitosing
reviewed
Nov 16, 2023
Comment on lines
+567
to
+570
| def save_implementation_data(nil, _, _, _), do: {nil, nil} | ||
|
|
||
| {:ok, implementation_address} = | ||
| case Contract.eth_get_storage_at_request( | ||
| proxy_address_hash, | ||
| master_copy_storage_pointer, | ||
| nil, | ||
| json_rpc_named_arguments | ||
| ) do | ||
| {:ok, empty_address} | ||
| when is_burn_signature(empty_address) -> | ||
| {:ok, "0x"} | ||
|
|
||
| {:ok, logic_contract_address} -> | ||
| {:ok, logic_contract_address} | ||
|
|
||
| _ -> | ||
| {:ok, nil} | ||
| end | ||
|
|
||
| abi_decode_address_output(implementation_address) | ||
| end | ||
|
|
||
| defp save_implementation_data(nil, _, _, _), do: {nil, nil} | ||
|
|
||
| defp save_implementation_data(empty_address_hash_string, proxy_address_hash, metadata_from_verified_twin, options) | ||
| when is_burn_signature_extended(empty_address_hash_string) do | ||
| def save_implementation_data(empty_address_hash_string, proxy_address_hash, metadata_from_verified_twin, options) | ||
| when is_burn_signature_extended(empty_address_hash_string) do |
There was a problem hiding this comment.
Shouldn't we union these 2 caluses to:
def save_implementation_data(empty_address_hash_string, proxy_address_hash, metadata_from_verified_twin, options)
when is_burn_signature_extended(empty_address_hash_string) or is_nil(empty_address_hash_string) do
It will allow us to save implementation_fetched_at for nil cases
There was a problem hiding this comment.
I'd suggest doing this in frame of a separate PR. Currently, I have doubts to implement this in suggested maneer. Anyways, changes in this PR don't touch this logic and targeted to solve other (not performance) problems. Please, create an issue for the case you're reffering to.
sl1depengwyn
approved these changes
Nov 16, 2023
nikitosing
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8758
Resolves #8760
Resolves #8761
Motivation
Refactor proxy smart-contracts detection and add missing proxy standards
Changelog
apps/explorer/lib/explorer/chain/smart_contract/proxypath:Explorer.ChaintoExplorer.Chain.SmartContract.Explorer.ChaintoExplorer.Chain.SmartContract.Proxy.Checklist for your Pull Request (PR)
CHANGELOG.mdwith this PRmasterin the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.