Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind to full prop namings in API v2 endpoints #2374

Closed
vbaranov opened this issue Nov 8, 2024 · 0 comments · Fixed by #2381
Closed

Bind to full prop namings in API v2 endpoints #2374

vbaranov opened this issue Nov 8, 2024 · 0 comments · Fixed by #2381
Assignees
Labels
v1.36.1 Release v1.36.1

Comments

@vbaranov
Copy link
Member

vbaranov commented Nov 8, 2024

Backend task blockscout/blockscout#10913

Starting from 6.9.0 of backend, all API v2 endpoints contains duplicates of shorthands of the props.

The general idea is to replace:

  • ...tx... and ...txn... with ...transaction...
  • ...num... with number.

The full set of renamings:

old prop name new prop name status comment
tx_hash transaction_hash
tx_number transaction_number prop is not used
creation_tx_hash creation_transaction_hash
tx_count transaction_count
tx_fees transaction_fees
tx_commitment transaction_commitment prop is not used
l1_tx_hashes l1_transaction_hashes
l1_tx_hash l1_transaction_hash
l1_tx_count l1_transaction_count
l1_tx_origin l1_transaction_origin
l2_tx_hash l2_transaction_hash
l2_tx_count l2_transaction_count
l2_tx_gas_limit l2_transaction_gas_limit
verify_tx_hash verify_transaction_hash
sequence_tx_hash sequence_transaction_hash
personal_tx_tag personal_transaction_tag prop is not used
block_num block_number prop is not used
tx_tag transaction_tag
has_error_in_internal_txs has_error_in_internal_transactions
index_int_tx_desc_order index_internal_transaction_desc_order
block block_number where block number is returned, not block object: internal transaction and transaction views. Both view are used in list and single object API endpoints
tx_types transaction_types

Please bind to new props in API endpoints. The next (6.10.0) release of the backend will remove old prop names.

@vbaranov vbaranov changed the title Bind to full namings in API v2 endpoints Bind to full prop namings in API v2 endpoints Nov 8, 2024
@tom2drum tom2drum self-assigned this Nov 11, 2024
tom2drum added a commit that referenced this issue Nov 11, 2024
@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.36.1 Release v1.36.1 and removed pre-release Tasks in pre-release right now labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.36.1 Release v1.36.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants