Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: envs validator and styles #1873

Merged
merged 4 commits into from
May 1, 2024
Merged

Hotfix: envs validator and styles #1873

merged 4 commits into from
May 1, 2024

Conversation

maxaleks
Copy link
Contributor

@maxaleks maxaleks commented Apr 30, 2024 •
edited
Loading

Description and Related Issue(s)

  • fixes fullscreen height on android
  • allows to use NEXT_PUBLIC_ADMIN_SERVICE_API_HOST when NEXT_PUBLIC_IS_ACCOUNT_SUPPORTED or NEXT_PUBLIC_MARKETPLACE_ENABLED is true

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@maxaleks maxaleks changed the title Hotfix: enva validator and styles Hotfix: envs validator and styles Apr 30, 2024
@maxaleks maxaleks requested a review from tom2drum April 30, 2024 14:02
@tom2drum tom2drum merged commit 5c3e1be into main May 1, 2024
15 of 16 checks passed
@tom2drum tom2drum deleted the hotfix-env-validator-and-styles branch May 1, 2024 12:22
@maxaleks maxaleks mentioned this pull request May 6, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom2drum tom2drum tom2drum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxaleks @tom2drum