Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "Scroll to active tab" behavior on mobile devices #2214

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Fix the "Scroll to active tab" behavior on mobile devices #2214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff15c87
fix scroll left position calculation when changing the tab
tom2drum Sep 5, 2024
8b785e6
do not scroll if the selected tab is on the first page
tom2drum Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions ui/shared/Tabs/useScrollToActiveTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,22 @@ export default function useScrollToActiveTab({ activeTabIndex, tabsRefs, listRef
const activeTabRef = tabsRefs[activeTabIndex];

if (activeTabRef.current && listRef.current) {
const activeTabRect = activeTabRef.current.getBoundingClientRect();
const containerWidth = listRef.current.getBoundingClientRect().width;
const activeTabWidth = activeTabRef.current.getBoundingClientRect().width;
const left = tabsRefs.slice(0, activeTabIndex)
.map((tab) => tab.current?.getBoundingClientRect())
.filter(Boolean)
.map((rect) => rect.width)
.reduce((result, item) => result + item, 0);

const isWithinFirstPage = containerWidth > left + activeTabWidth;

if (isWithinFirstPage) {
return;
}

listRef.current.scrollTo({
left: activeTabRect.left,
left,
behavior: 'smooth',
});
}
Expand Down
Loading