Quic Proxy: cleanup/consolidate tests, handle flaky tests, add explicit connection close #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
grooviegermanikus
commented
Aug 21, 2023
•
grooviegermanikus
commented
- add explicit tpu connect shutdown
- remove redundant integration test (literpc_tpu_quic_server_integrationtest.rs) and use the quic_proxy_tpu_integrationtest.rs for everything
- remove some commands from test.bash
- remove redundant integration test (literpc_tpu_quic_server_integrationtest.rs) and use the quic_proxy_tpu_integrationtest.rs for everything - remove some commands from test.bash
godmodegalactus
previously requested changes
Aug 21, 2023
…solidate-integration-tests
grooviegermanikus
changed the title
grooviegermanikus
dismissed
godmodegalactus’s stale review
reverted the change
godmodegalactus
previously approved these changes
Aug 29, 2023
grooviegermanikus
dismissed
godmodegalactus’s stale review
The merge-base changed after approval.
godmodegalactus
previously approved these changes
Aug 29, 2023
grooviegermanikus
dismissed
godmodegalactus’s stale review
The merge-base changed after approval.
This reverts commit 50907f3.
aniketfuryrocks
previously approved these changes
Aug 29, 2023
grooviegermanikus
dismissed
aniketfuryrocks’s stale review
The merge-base changed after approval.
aniketfuryrocks
previously approved these changes
Aug 29, 2023
grooviegermanikus
dismissed
aniketfuryrocks’s stale review
The merge-base changed after approval.
godmodegalactus
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.