Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mc/ix toggler #419

Merged
merged 5 commits into from
Jan 26, 2023
Merged

Mc/ix toggler #419

merged 5 commits into from
Jan 26, 2023

Conversation

microwavedcola1
Copy link
Collaborator

No description provided.

@microwavedcola1 microwavedcola1 force-pushed the mc/ix-toggler branch 2 times, most recently from 6a487b2 to 258f619 Compare January 24, 2023 07:34
@github-actions github-actions bot added the program On-chain program changes label Jan 24, 2023
@microwavedcola1 microwavedcola1 force-pushed the mc/ix-toggler branch 4 times, most recently from 998d0b6 to aae2b4f Compare January 24, 2023 07:55
@github-actions github-actions bot added the client TS client changes label Jan 24, 2023
@microwavedcola1 microwavedcola1 force-pushed the mc/ix-toggler branch 6 times, most recently from f721713 to 5cbd9a0 Compare January 24, 2023 10:19
@microwavedcola1
add gating to individual ixs
35d4a23 
Signed-off-by: microwavedcola1 <microwavedcola@gmail.com>
ckamm
ckamm reviewed Jan 24, 2023
View reviewed changes
programs/mango-v4/src/error.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/error.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/instructions/ix_gate_set.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/state/group.rs Show resolved Hide resolved
programs/mango-v4/src/state/group.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/state/group.rs Outdated Show resolved Hide resolved
programs/mango-v4/tests/test_ix_gate_set.rs Outdated Show resolved Hide resolved
ts/client/src/clientIxParamBuilder.ts Outdated Show resolved Hide resolved
@microwavedcola1 microwavedcola1 force-pushed the mc/ix-toggler branch 2 times, most recently from b1d65ee to 808c2cc Compare January 24, 2023 15:38
@microwavedcola1
fixes from review
36e8d1e 
Signed-off-by: microwavedcola1 <microwavedcola@gmail.com>
ckamm
ckamm reviewed Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@ckamm ckamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test that disables all instructions, just to confirm it fits into cu budget?

programs/mango-v4/src/instructions/health_region.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/instructions/ix_gate_set.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/instructions/ix_gate_set.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/instructions/ix_gate_set.rs Outdated Show resolved Hide resolved
programs/mango-v4/tests/program_test/mango_client.rs Outdated Show resolved Hide resolved
programs/mango-v4/tests/test_ix_gate_set.rs Show resolved Hide resolved
@microwavedcola1
fixes from review
ac79432 
Signed-off-by: microwavedcola1 <microwavedcola@gmail.com>
@microwavedcola1
fixes from review
ace3ddd 
Signed-off-by: microwavedcola1 <microwavedcola@gmail.com>
@microwavedcola1
fixes from review
fc0a0df 
Signed-off-by: microwavedcola1 <microwavedcola@gmail.com>
@microwavedcola1 microwavedcola1 merged commit 0012907 into dev Jan 26, 2023
@microwavedcola1 microwavedcola1 deleted the mc/ix-toggler branch January 26, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckamm ckamm ckamm approved these changes

Assignees
No one assigned
Labels
client TS client changes program On-chain program changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microwavedcola1 @ckamm