fix/broken Cypress tests on master #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyjablonski
added
the
wip
|
Deploy preview for clever-edison-cd22c1 ready! Built with commit ad736c9 https://deploy-preview-1138--clever-edison-cd22c1.netlify.app |
emilyjablonski
changed the title
|
Deploy preview for clever-edison-cd22c1 ready! Built with commit 0a64c5d https://deploy-preview-1138--clever-edison-cd22c1.netlify.app |
|
@pbn4 Just as a heads up |
emilyjablonski
added
ready for review
and removed
wip
|
@emilyjablonski I just fixed the test checks for where slugs have changed, sorry again for the inconvenience. :) |
|
@pbn4 Thanks for taking a look! This was the approach I tried first and I couldn't get the tests to pass locally, and I still cannot. I have re-seeded, is there something else I need to do locally for the tests to pass? |
YazeedLoonat
added a commit
to YazeedLoonat/bloom
that referenced
this pull request
May 31, 2022
* 1058/updated public listing filters (bloom-housing#1138) * feat: fixes backend to filter properly * fix: some touch ups * fix: updates per emily * fix: updates per emily * fix: fixes for tests * fix: updates per emily * fix: matching filters to mocks * fix: remove test class * fix: updates per emily * fix: reset fix * fix: fix for the tests * fix: modifying the region filter to be an OR * fix: test updates Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The navigation suite was broken by this PR #1124 (It's not flake, the suite is failing consistently / broken after the change - looks like changing the listing name changes the URL slug)