-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a notice bar to the preview page of a listing #1532
Conversation
✔️ Deploy Preview for dev-bloom ready! 🔨 Explore the source changes: d4d4f55 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/61001c72892b56000795c0b7 😎 Browse the preview: https://deploy-preview-1532--dev-bloom.netlify.app |
✔️ Deploy Preview for dev-partners-bloom ready! 🔨 Explore the source changes: d4d4f55 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/61001c722bb133000858d211 😎 Browse the preview: https://deploy-preview-1532--dev-partners-bloom.netlify.app |
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: d4d4f55 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/61001c72bdc80d0008cb838e 😎 Browse the preview: https://deploy-preview-1532--dev-storybook-bloom.netlify.app |
✔️ Deploy Preview for jovial-davinci-1d67a0 ready! 🔨 Explore the source changes: d4d4f55 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-davinci-1d67a0/deploys/61001c72ca8c0300089a8c75 😎 Browse the preview: https://deploy-preview-1532--jovial-davinci-1d67a0.netlify.app |
@jaredcwhite Originally I had designed this to be a top of the page element. Was that not possible or did you think this new placement was more appropriate? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, @jaredcwhite , and matches the comps.
@slowbot I would say it's easier to implement this within the individual page region, rather than try to monkey with the overall layout (aka header/footer). |
* Add a notice bar to the preview page of a listing * Move style to TW classes * Update changelog with #1507 Co-authored-by: seanmalbert <smabert@gmail.com>
Pull Request Template
Issue
Addresses #1507
Description
When previewing a listing from the partners portal, a preview banner is shown at the top of the listing.
Type of change
How Can This Be Tested/Reviewed?
Sign into the portal and then preview a listing! 😉 Alternatively go to a public listing and then change the url format to
preview/listings/[id]
Checklist: