Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1685/upgrade to next 11 #1793

Closed
wants to merge 6 commits into from
Closed

1685/upgrade to next 11 #1793

wants to merge 6 commits into from

Conversation

jaredcwhite
Copy link
Collaborator

@jaredcwhite jaredcwhite commented Sep 2, 2021 •
edited
Loading

Pull Request Template

Issue

Addresses #1685

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Both partners and public sites are upgraded to Next 11 (and Webpack 5), plus React is bumped to v17 across the sites and ui-components packages.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Please describe the tests that you ran to verify your changes. Provide instructions so we can review. Please also list any relevant details for your test configuration

  • Desktop View
  • Mobile View
  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@netlify
Copy link

netlify bot commented Sep 2, 2021 •
edited
Loading

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: daa4516

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/6133004e088f8b000729812c

😎 Browse the preview: https://deploy-preview-1793--dev-storybook-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 2, 2021 •
edited
Loading

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: daa4516

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/6133004e46b80f00088b0048

😎 Browse the preview: https://deploy-preview-1793--dev-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 2, 2021 •
edited
Loading

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: daa4516

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/6133004eb77c3000076afcbe

😎 Browse the preview: https://deploy-preview-1793--dev-partners-bloom.netlify.app

@jaredcwhite jaredcwhite added dependencies Pull requests that update a dependency file tech debt Long-term required changes that has been push down the road wip This PR is not ready for review, do not review it's a “Work In Progress” labels Sep 2, 2021
@netlify
Copy link

netlify bot commented Sep 4, 2021 •
edited
Loading

✔️ Deploy Preview for clever-edison-cd22c1 ready!

🔨 Explore the source changes: daa4516

🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/6133004e416fd30007bc5a28

😎 Browse the preview: https://deploy-preview-1793--clever-edison-cd22c1.netlify.app

@jaredcwhite jaredcwhite removed the wip This PR is not ready for review, do not review it's a “Work In Progress” label Sep 7, 2021
@seanmalbert seanmalbert mentioned this pull request Sep 8, 2021
Closed
@seanmalbert
Copy link
Collaborator

Noting that @jaredcwhite's PR #1805, is based off of this, and when that's ready, we can close this.

@jaredcwhite
Copy link
Collaborator Author

Closing in favor of #1805.

seanmalbert added a commit that referenced this pull request Sep 14, 2021
@jaredcwhite @lint-action @seanmalbert
Upgrade to tailwind v2 (#1805)
d348a01 
* Upgrade to Next 11 and React 17

* Switch pages from MDX to markdown-to-jsx

* Also remove unneeded React imports

* Use tsx for Next error pages

* Fix lack of semantic heading on Listing photo form

* Add #1793 to Changelog

* Upgrade to Tailwind 2, PostCSS 8, Storybook 6.3

* Upgade Changelook with #1805

* Upgrade to Node 14

* Update `.node-version` file

* Testing explicit tailwind dep on Netlify

* Update partners also with tailwind dep

* Update Node version in CircleCI

* Use Node 14.17.4 instead for security fixes

* Whoops, make that 14.17.6 =)

* Bump Cypress in CircleCI back down to 14.17.0

(there's no newer Docker image available at present)

* Bump up React Hook Form in public app

* Fix lockfile, update GitHub lint action

* Remove stray </td> causing a linting issue

* Fix code style issues with Prettier

* new lines on two files

* export updates

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>
seanmalbert added a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
@jaredcwhite @lint-action @seanmalbert
Upgrade to tailwind v2 (bloom-housing#1805)
b2767b6 
* Upgrade to Next 11 and React 17

* Switch pages from MDX to markdown-to-jsx

* Also remove unneeded React imports

* Use tsx for Next error pages

* Fix lack of semantic heading on Listing photo form

* Add bloom-housing#1793 to Changelog

* Upgrade to Tailwind 2, PostCSS 8, Storybook 6.3

* Upgade Changelook with bloom-housing#1805

* Upgrade to Node 14

* Update `.node-version` file

* Testing explicit tailwind dep on Netlify

* Update partners also with tailwind dep

* Update Node version in CircleCI

* Use Node 14.17.4 instead for security fixes

* Whoops, make that 14.17.6 =)

* Bump Cypress in CircleCI back down to 14.17.0

(there's no newer Docker image available at present)

* Bump up React Hook Form in public app

* Fix lockfile, update GitHub lint action

* Remove stray </td> causing a linting issue

* Fix code style issues with Prettier

* new lines on two files

* export updates

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmalbert seanmalbert Awaiting requested review from seanmalbert

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file tech debt Long-term required changes that has been push down the road
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredcwhite @seanmalbert