Contribute Detroit filters to Bloom

[abbiefarr]

Issue

Addresses CityOfDetroit#566

• This change addresses the issue in full
• This change addresses only certain aspects of the issue
• This change is a dependency for another issue
• This change has a dependency from another issue

Description

Apologies for the large PR. For most of us this is the last week on the project, so I'm trying to make this contribution before I leave the team.

This PR contributes a number of Detroit's filters upstream, with the intention to add functionality and keep our code bases as synced as possible.

Some new filters follow the standard filters code path with regular comparisons (e.g. minRent). Others require special clauses, which have been pulled out into a separate file called custom_filters.ts.

Contributed filters include:

• seniorHousing: this is pulled from the reservedCommunityType column. It checks for a match with "senior62" in the database. This is added as a custom filter.
• minRent and maxRent: these are pulled from unitsSummary.monthly_rent_[min|max], and implemented as normal >= or <= filters.
• ami: pulls from unitsSummary.ami_percentage if that is populated, otherwise queries listings.ami_percentage_max. Checks for values >= the provided AMI.
• availability: There are 3 possible values for availability: hasAvailability, noAvailability, and waitlist. Results are queried from unitsSummary.total_available if the filter is for has or no availability. Pulls from listings.is_waitlist_open if the filter is for a waitlist.

The addition of $include_nulls to BaseFilter is also included. If set to true, null values will be considered a match on the filter and will be returned in the results. This is useful if data is incomplete.

We also trivially added a <= comparison filter.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Prototype/POC (not to merge)
• This change is a refactor/address technical debt
• This change requires a documentation update
• This change requires a SQL Script

How Can This Be Tested/Reviewed?

Unit tests were added for the $include_nulls functionality.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have reviewed the changes in a desktop view
• I have reviewed the changes in a mobile view
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have assigned reviewers
• I have updated the changelog to include a description of my changes
• I have run yarn generate:client if I made backend changes

[netlify]

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: da01c87

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/615b975a62815600089ef16c

😎 Browse the preview: https://deploy-preview-1884--dev-partners-bloom.netlify.app

[netlify]

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: da01c87

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/615b975ac245810008b6ca5f

😎 Browse the preview: https://deploy-preview-1884--dev-bloom.netlify.app

[netlify]

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: da01c87

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/615b975a17f78700073c4702

😎 Browse the preview: https://deploy-preview-1884--dev-storybook-bloom.netlify.app

[abbiefarr]

@seanmalbert failures don't seem related, but I can't find how to retrigger a build. So I'll say this is ready for review, and if you have any insight into the test failures that would be very appreciated!

[emilyjablonski]

@seanmalbert Test failures look unrelated to this PR to me :)

[seanmalbert]

Thank you for contributing these filters, @abbiefarr!