Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): unitCreate and UnitUpdateDto now require only IdDto for… #1956

Merged
merged 6 commits into from
Oct 12, 2021

Conversation

pbn4
Copy link
Contributor

@pbn4 pbn4 commented Oct 7, 2021

… related properties

Related to #1897, UnitCreateDto specified UnitTypeCreateDto as an input and as a result (no id
provided) it created a new unit type on each form submission.

BREAKING CHANGE: POST/PUT /listings interface change

Pull Request Template

Issue

Addresses # (#1897 )

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

UnitCreateDto model changes to prevent form submission from creating UnitType, UnitRentType and AccessibilityType from creating a new DB row on each submission.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Please describe the tests that you ran to verify your changes. Provide instructions so we can review. Please also list any relevant details for your test configuration

  • Desktop View
  • Mobile View
  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes

@netlify
Copy link

netlify bot commented Oct 7, 2021

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 9f63e99

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/6165ded2630898000732b154

😎 Browse the preview: https://deploy-preview-1956--dev-storybook-bloom.netlify.app

@netlify
Copy link

netlify bot commented Oct 7, 2021

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 9f63e99

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/6165ded12f262d0008517240

😎 Browse the preview: https://deploy-preview-1956--dev-bloom.netlify.app

@netlify
Copy link

netlify bot commented Oct 7, 2021

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 9f63e99

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/6165ded19cd9a00007369ab5

😎 Browse the preview: https://deploy-preview-1956--dev-partners-bloom.netlify.app

… related properties

Related to #1897, UnitCreateDto specified UnitTypeCreateDto as an input and as a result (no id
provided) it created a new unit type on each form submission.

BREAKING CHANGE: POST/PUT /listings interface change
@pbn4 pbn4 force-pushed the 1897/unit_type_resets_bug branch from 5369dba to 5dc3f8d Compare October 7, 2021 07:35
@seanmalbert seanmalbert merged commit 43dcfbe into dev Oct 12, 2021
seanmalbert added a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
bloom-housing#1956)

* fix(backend): unitCreate and UnitUpdateDto now require only IdDto for related properties

Related to bloom-housing#1897, UnitCreateDto specified UnitTypeCreateDto as an input and as a result (no id
provided) it created a new unit type on each form submission.

BREAKING CHANGE: POST/PUT /listings interface change

* fix: updates ui component version

* Fix code style issues with Prettier

* fix(backend-swagger): manually add totalFlagged until fixed

Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants