-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): unitCreate and UnitUpdateDto now require only IdDto for… #1956
Conversation
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: 9f63e99 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/6165ded2630898000732b154 😎 Browse the preview: https://deploy-preview-1956--dev-storybook-bloom.netlify.app |
✔️ Deploy Preview for dev-bloom ready! 🔨 Explore the source changes: 9f63e99 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/6165ded12f262d0008517240 😎 Browse the preview: https://deploy-preview-1956--dev-bloom.netlify.app |
✔️ Deploy Preview for dev-partners-bloom ready! 🔨 Explore the source changes: 9f63e99 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/6165ded19cd9a00007369ab5 😎 Browse the preview: https://deploy-preview-1956--dev-partners-bloom.netlify.app |
… related properties Related to #1897, UnitCreateDto specified UnitTypeCreateDto as an input and as a result (no id provided) it created a new unit type on each form submission. BREAKING CHANGE: POST/PUT /listings interface change
5369dba
to
5dc3f8d
Compare
bloom-housing#1956) * fix(backend): unitCreate and UnitUpdateDto now require only IdDto for related properties Related to bloom-housing#1897, UnitCreateDto specified UnitTypeCreateDto as an input and as a result (no id provided) it created a new unit type on each form submission. BREAKING CHANGE: POST/PUT /listings interface change * fix: updates ui component version * Fix code style issues with Prettier * fix(backend-swagger): manually add totalFlagged until fixed Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
… related properties
Related to #1897, UnitCreateDto specified UnitTypeCreateDto as an input and as a result (no id
provided) it created a new unit type on each form submission.
BREAKING CHANGE: POST/PUT /listings interface change
Pull Request Template
Issue
Addresses # (#1897 )
Description
UnitCreateDto model changes to prevent form submission from creating UnitType, UnitRentType and AccessibilityType from creating a new DB row on each submission.
Type of change
How Can This Be Tested/Reviewed?
Please describe the tests that you ran to verify your changes. Provide instructions so we can review. Please also list any relevant details for your test configuration
Checklist:
yarn generate:client
if I made backend changes