Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved UX for the Building Selection Criteria drawer #1994

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

jaredcwhite
Copy link
Collaborator

Issue

Addresses QA feedback from #1755

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This improves the experience of clicking Save without selecting an attachment option (it will now do the same thing as Cancel). In addition, the drawer will now reset to the state of showing the two attachment options more reliably.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/addresses technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Try editing an existing Building Selection Criteria row in the Listings MVP.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes
  • I have exported any new pieces in ui-components

@netlify
Copy link

netlify bot commented Oct 14, 2021

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 191c2cb

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/61688fcebecbaa00080f96d2

😎 Browse the preview: https://deploy-preview-1994--dev-partners-bloom.netlify.app

@netlify
Copy link

netlify bot commented Oct 14, 2021

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 191c2cb

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/61688fce954b6d0008e14e28

😎 Browse the preview: https://deploy-preview-1994--dev-storybook-bloom.netlify.app

@netlify
Copy link

netlify bot commented Oct 14, 2021

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 191c2cb

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/61688fcee766e3000775d637

😎 Browse the preview: https://deploy-preview-1994--dev-bloom.netlify.app

@jaredcwhite jaredcwhite merged commit 4bd8b09 into dev Oct 14, 2021
seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
…using#1994)

* fix: improved ux for Building Selection Criteria drawer

* Updated changelog with bloom-housing#1994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant