Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove electron #3655

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: remove electron #3655

merged 1 commit into from
Sep 27, 2023

Conversation

ludtkemorgan
Copy link
Collaborator

@ludtkemorgan ludtkemorgan commented Sep 25, 2023

This dependency is frequently flagged by security checks and in the process of upgrading it, I noticed it doesn't appear to be used anywhere. I would also assume if it was used it would be in the public package file as well.

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for bloom-demo-public ready!

Name Link
🔨 Latest commit da168c3
🔍 Latest deploy log https://app.netlify.com/sites/bloom-demo-public/deploys/6511e2dc908b0d000847b37d
😎 Deploy Preview https://deploy-preview-3655--bloom-demo-public.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for bloom-partners-listings-approval ready!

Name Link
🔨 Latest commit da168c3
🔍 Latest deploy log https://app.netlify.com/sites/bloom-partners-listings-approval/deploys/6511e2dce0bb370008d46ed4
😎 Deploy Preview https://deploy-preview-3655--bloom-partners-listings-approval.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit da168c3
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/6511e2dbb3c0d200088805ff
😎 Deploy Preview https://deploy-preview-3655--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ludtkemorgan ludtkemorgan marked this pull request as ready for review September 26, 2023 15:27
@ludtkemorgan ludtkemorgan added the 2 reviews needed Requires 2 more review before ready to merge label Sep 26, 2023
@emilyjablonski emilyjablonski added 1 review needed Requires 1 more review before ready to merge and removed 2 reviews needed Requires 2 more review before ready to merge labels Sep 26, 2023
Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👠

@ColinBuyck ColinBuyck added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Sep 26, 2023
@ludtkemorgan ludtkemorgan merged commit a164473 into main Sep 27, 2023
12 checks passed
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request Oct 10, 2023
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request Oct 12, 2023
* fix: jurisdiction permission array approach (bloom-housing#3644)

* fix: remove electron (bloom-housing#3655)

* feat: application export now emailed (bloom-housing#3661)

---------

Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com>
YazeedLoonat added a commit that referenced this pull request Nov 20, 2023
* fix: remove electron (#3655)

* feat: application export now emailed (#3661)

* fix: alphabetical listing order (#3678)

* chore(deps): bump @babel/traverse from 7.21.2 to 7.23.2 (#3685)

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.21.2 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: email is sent async and response is immediate (#3684)

* fix: email is sent async and response is immediate

* fix: update for tests

* fix: test updates

* feat: replace UIC `GridSection` with Seeds `Grid` (#3643)

* feat: uptake Grid component from Seeds

* feat: finish Grid component uptake

* feat: update recent changes from main

* fix: mangled syntax

* fix: switch prop to class name

* chore: address linting issues

* fix: typo

* fix: make sure old UIC labels look more modern

* test: use new seeds classes in test selector

* test: resolve issue with grid and Cypress selector

* test: fix bad ids

* fix: grid and form layouts based on feedback

* fix: remove old GridCell, tighten up spacing on Partners aside

* fix: column layout issues from feedback

* chore: grid spacing updates (anticipating Seeds fixes)

* chore: update to latest Seeds

* fix: grid fix for listing intro (#3701)

* fix: listingName, approval email from listingJuris (#3700)

* chore(deps): bump undici from 5.20.0 to 5.26.3 (#3680)

Bumps [undici](https://github.com/nodejs/undici) from 5.20.0 to 5.26.3.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.20.0...v5.26.3)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: geocoding geographic radius set up (#3692)

* feat: add collectAddress checkbox with subfields

* test: update preference tests

* fix: add minimum value validation for radius field

* fix: make collect address not required

* fix: expand collect address fields

* fix: change fields order in PreferenceDrawer

* fix: align styles to design

add error message

* fix: add feature flag for geocoding (#3711)

* fix: add feature flag for geocoding

* fix: grid fix for options

* fix: test fixes

* fix: new tests

* fix: add new geocoding features

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com>
Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants