Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Paper Application not saving lat long #3828

Merged
merged 3 commits into from
Jan 26, 2024
Merged

fix: Paper Application not saving lat long #3828

merged 3 commits into from
Jan 26, 2024

Conversation

KrissDrawing
Copy link
Collaborator

Pull Request Template

Issue Overview

This PR addresses #3810

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Add maps to preference options with address, that will include latitude and longitude in option address object.
I got to exclude extraData field from submitting when option is unchecked, which seem expected, but let me know if you see any possible issues with that.
Also this will be visible in non geocoding app (as is address verification step in digital application).

How Can This Be Tested/Reviewed?

  1. Create paper application that has preference option with validation address radius method set.
  2. select that option, fill address and save.
  3. Export applications -> Passed Address Check cell for that option should be either yes or no instead of Needs Manual Verification

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@KrissDrawing KrissDrawing added the 2 reviews needed Requires 2 more review before ready to merge label Jan 24, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 24, 2024 •
edited
Loading

✅ Deploy Preview for bloom-demo-public ready!

Name Link
🔨 Latest commit 3b329b5
🔍 Latest deploy log https://app.netlify.com/sites/bloom-demo-public/deploys/65b14da43b9e180008c13481
😎 Deploy Preview https://deploy-preview-3828--bloom-demo-public.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 24, 2024 •
edited
Loading

✅ Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 128b427
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/65b3cbb7db9c020008a1e10b
😎 Deploy Preview https://deploy-preview-3828--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ColinBuyck
ColinBuyck reviewed Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! The only issue I found was that saving a paper application without any preferences selected and then editing it to include an address for a verified preference results in the address check field coming through blank in the csv

sites/partners/src/components/applications/PaperApplicationForm/MultiselectQuestionsMap.tsx Outdated Show resolved Hide resolved
@KrissDrawing
Copy link
Collaborator Author

@ColinBuyck Oh right, can't believe i missed that 😄 Geocoding verification was only triggering on application create, which was logical as we didn't have lat and long on edit before.

Also didn't dig too much into that backend radius verification i just checked that it works also on edit. So @ludtkemorgan if you have any objections about that, let me know.

ludtkemorgan
ludtkemorgan approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for making the edit application changes

sites/partners/src/components/applications/PaperApplicationForm/MultiselectQuestionsMap.tsx Show resolved Hide resolved
...tners/src/components/applications/PaperApplicationForm/sections/FormMultiselectQuestions.tsx Show resolved Hide resolved
@ludtkemorgan ludtkemorgan added 1 review needed Requires 1 more review before ready to merge and removed 2 reviews needed Requires 2 more review before ready to merge labels Jan 26, 2024
ColinBuyck
ColinBuyck approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛷️ Thanks for making those updates so quickly!

@ColinBuyck ColinBuyck added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge ready to merge Should be applied when a PR has been reviewed and approved labels Jan 26, 2024
@ludtkemorgan ludtkemorgan merged commit 3ea47ed into main Jan 26, 2024
20 checks passed
ludtkemorgan pushed a commit to housingbayarea/bloom that referenced this pull request Jan 26, 2024
@KrissDrawing @ludtkemorgan
fix: Paper Application not saving lat long (bloom-housing#3828)
0c6eea6 
* fix: add map ui to include lat and long in paper application preference options

* refactor: remove redundant class

* fix: trigger geocoding validation on listing update
@ludtkemorgan ludtkemorgan mentioned this pull request Jan 26, 2024
Merged
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request Jan 30, 2024
@ludtkemorgan @KrissDrawing
Release/2024 01 26 (#659)
8ca5e06 
* fix: geocoding verification fix (bloom-housing#3832)

* fix: geocoding verification fix

* fix: e2e test fix

* fix: add submit to sms mfa flow (bloom-housing#3838)

* fix: Paper Application not saving lat long (bloom-housing#3828)

* fix: add map ui to include lat and long in paper application preference options

* refactor: remove redundant class

* fix: trigger geocoding validation on listing update

---------

Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com>
@ludtkemorgan ludtkemorgan mentioned this pull request Jan 30, 2024
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinBuyck ColinBuyck ColinBuyck approved these changes

@ludtkemorgan ludtkemorgan ludtkemorgan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KrissDrawing @ludtkemorgan @ColinBuyck