-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add releaseDate to partner card #4315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinBuyck
added
the
1 review needed
Requires 1 more review before ready to merge
label
Sep 10, 2024
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ColinBuyck
added
not ready yet
Not ready for review, do not review it’s a WIP
and removed
1 review needed
Requires 1 more review before ready to merge
labels
Sep 10, 2024
ColinBuyck
force-pushed
the
4300/publish-lottery-bug
branch
from
September 10, 2024 21:44
8107a93
to
b717e1f
Compare
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ColinBuyck
commented
Sep 10, 2024
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ColinBuyck
added
1 review needed
Requires 1 more review before ready to merge
and removed
not ready yet
Not ready for review, do not review it’s a WIP
labels
Sep 10, 2024
emilyjablonski
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎰
emilyjablonski
added
ready to merge
Should be applied when a PR has been reviewed and approved
and removed
1 review needed
Requires 1 more review before ready to merge
labels
Sep 11, 2024
ColinBuyck
added a commit
to housingbayarea/bloom
that referenced
this pull request
Sep 13, 2024
* fix: complete todo * fix: findLast alternative
ColinBuyck
added a commit
to metrotranscom/doorway
that referenced
this pull request
Sep 13, 2024
* fix: complete todo * fix: findLast alternative
emilyjablonski
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Sep 13, 2024
* fix: complete todo * fix: findLast alternative
ColinBuyck
added a commit
to housingbayarea/bloom
that referenced
this pull request
Sep 30, 2024
* fix: complete todo * fix: findLast alternative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #4300
Description
This PR completes an outstanding todo to include the releaseDate in the partners messaging seen in the issue description. It also handles the case of releasing and retracting by finding the most recent release date.
How Can This Be Tested/Reviewed?
This can be tested by creating a lottery listing as an admin and releasing that lottery. Then as a partner user see the date and time reflected in the lottery publish card. You can also test retracting and releasing the lottery to see the time updated.
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: