Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add releaseDate to partner card #4315

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

ColinBuyck
Copy link
Collaborator

This PR addresses #4300

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR completes an outstanding todo to include the releaseDate in the partners messaging seen in the issue description. It also handles the case of releasing and retracting by finding the most recent release date.

How Can This Be Tested/Reviewed?

This can be tested by creating a lottery listing as an admin and releasing that lottery. Then as a partner user see the date and time reflected in the lottery publish card. You can also test retracting and releasing the lottery to see the time updated.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@ColinBuyck ColinBuyck added the 1 review needed Requires 1 more review before ready to merge label Sep 10, 2024
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 3e78c3a
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/66e383b25e47c10009150354
😎 Deploy Preview https://deploy-preview-4315--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ColinBuyck ColinBuyck added not ready yet Not ready for review, do not review it’s a WIP and removed 1 review needed Requires 1 more review before ready to merge labels Sep 10, 2024
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 8107a93
🔍 Latest deploy log https://app.netlify.com/sites/partners-bloom-dev/deploys/66e0bd6edb82620009980bbc
😎 Deploy Preview https://deploy-preview-4315--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 3e78c3a
🔍 Latest deploy log https://app.netlify.com/sites/partners-bloom-dev/deploys/66e383b2d9bccf0008373021
😎 Deploy Preview https://deploy-preview-4315--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ColinBuyck ColinBuyck added 1 review needed Requires 1 more review before ready to merge and removed not ready yet Not ready for review, do not review it’s a WIP labels Sep 10, 2024
Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎰

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Sep 11, 2024
@ColinBuyck ColinBuyck merged commit 157704f into main Sep 13, 2024
19 of 20 checks passed
@ColinBuyck ColinBuyck deleted the 4300/publish-lottery-bug branch September 13, 2024 00:41
ColinBuyck added a commit to housingbayarea/bloom that referenced this pull request Sep 13, 2024
* fix: complete todo

* fix: findLast alternative
ColinBuyck added a commit to metrotranscom/doorway that referenced this pull request Sep 13, 2024
* fix: complete todo

* fix: findLast alternative
emilyjablonski pushed a commit to metrotranscom/doorway that referenced this pull request Sep 13, 2024
* fix: complete todo

* fix: findLast alternative
ColinBuyck added a commit to housingbayarea/bloom that referenced this pull request Sep 30, 2024
* fix: complete todo

* fix: findLast alternative
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants