Support classExpressions in DTE #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to see where it's actually being used. Signed-off-by: Hana Joo <hanajoo@google.com>
h-joo
force-pushed
the
classExpressions
branch
from
7d5174e
to
39bbe59
Compare
This is a non-functional move. Signed-off-by: Hana Joo <hanajoo@google.com>
as it's doing trivial bitwise OR operation, also some other parts of the code is doing |= instead, so try to be consistent. Signed-off-by: Hana Joo <hanajoo@google.com>
if there's any error reported. Signed-off-by: Hana Joo <hanajoo@google.com>
to reduce unncessary type checks Signed-off-by: Hana Joo <hanajoo@google.com>
Also, avoid unncessary work caused by calling invalid(), rather call reportIsolatedDeclarationError instead as it was the only thing intended. Signed-off-by: Hana Joo <hanajoo@google.com>
Signed-off-by: Hana Joo <hanajoo@google.com>
Signed-off-by: Hana Joo <hanajoo@google.com>
These seems all reasonable, we might have missed something before that was not updated. Signed-off-by: Hana Joo <hanajoo@google.com>
h-joo
force-pushed
the
classExpressions
branch
2 times, most recently
from
95c6bdc
to
a990f05
Compare
Signed-off-by: Hana Joo <hanajoo@google.com>
h-joo
force-pushed
the
classExpressions
branch
from
a990f05
to
e9ca3d4
Compare
This commit is totally non-functional Signed-off-by: Hana Joo <hanajoo@google.com>
dragomirtitian
requested changes
Oct 18, 2023
src/compiler/transformers/declarations/localInferenceResolver.ts
Outdated
Show resolved
Hide resolved
src/compiler/transformers/declarations/localInferenceResolver.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+65
to
+82
| let C = (() => { | ||
| let _classDecorators = [dec]; | ||
| let _classDescriptor; | ||
| let _classExtraInitializers = []; | ||
| let _classThis; | ||
| var C = class { | ||
| static { _classThis = this; } | ||
| static { | ||
| __esDecorate(null, _classDescriptor = { value: this }, _classDecorators, { kind: "class", name: this.name }, null, _classExtraInitializers); | ||
| const _metadata = typeof Symbol === "function" && Symbol.metadata ? Object.create(null) : void 0; | ||
| __esDecorate(null, _classDescriptor = { value: _classThis }, _classDecorators, { kind: "class", name: _classThis.name, metadata: _metadata }, null, _classExtraInitializers); | ||
| C = _classThis = _classDescriptor.value; | ||
| if (_metadata) Object.defineProperty(_classThis, Symbol.metadata, { enumerable: true, configurable: true, writable: true, value: _metadata }); | ||
| __runInitializers(_classThis, _classExtraInitializers); | ||
| } | ||
| }; | ||
| return C = _classThis; | ||
| })(); | ||
| export default C; |
There was a problem hiding this comment.
I have no idea, this seemed to be broken already in the target branch, but I don't have a good imagination to understand what would have caused this to change.
src/compiler/transformers/declarations/localInferenceResolver.ts
Outdated
Show resolved
Hide resolved
src/compiler/transformers/declarations/localInferenceResolver.ts
Outdated
Show resolved
Hide resolved
src/compiler/transformers/declarations/localInferenceResolver.ts
Outdated
Show resolved
Hide resolved
1. Reuse reusable chunk of code. 2. Proper handling of accessors, before it treated as if there were only a single accessor in the class. 3. Improve wording in the error message for heritage clauses Signed-off-by: Hana Joo <hanajoo@google.com>
dragomirtitian
requested changes
Oct 19, 2023
src/compiler/transformers/declarations/localInferenceResolver.ts
Outdated
Show resolved
Hide resolved
| const type = localInferenceFromInitializer(member, member.type); | ||
| if (!type) { | ||
| const { method, flags } = handleMethodDeclaration(member, member.name, NarrowBehavior.None); | ||
| if (flags === LocalTypeInfoFlags.Invalid) { |
There was a problem hiding this comment.
Could you please test with & for the invalid flag. Currently there is only one flag (used to be more) but I would like to keep the idea of this being a flag enum at least for now.
1. use bitwise AND instead of comparison 2. report errors on property name for object literals instead of the object literal Signed-off-by: Hana Joo <hanajoo@google.com>
dragomirtitian
merged commit e878ebd
into
bloomberg:isolated-declarations
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except for the commit e9ca3d4 everything else is non-functional, all others are fixing tests and moving things around, formatting.