Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolated declarations tests #103

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

dragomirtitian
Copy link

Integrate original (tsc tests with isolated declarations turned on) back in tsc main tests.

Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
…isolated declaration errors.

Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Copy link

@h-joo h-joo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good, but did you want me to also take a through look onto the diff file changes or references as well?

@dragomirtitian
Copy link
Author

@h-joo It would be useful to have a look. I still have not added the reason for each diff, so there will definitely be another PR for that maybe that would be a better moment to assess the diff more thoroughly.

@dragomirtitian dragomirtitian merged commit 46e9453 into isolated-declarations Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants