Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolated declarations evaluator #108

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Isolated declarations evaluator #108

merged 1 commit into from
Nov 14, 2023

Conversation

dragomirtitian
Copy link

Removed duplicate evaluator.

@dragomirtitian
Refactor evaluator to be outside the checker.
fca6fb1 
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
h-joo
h-joo approved these changes Nov 14, 2023
View reviewed changes
Copy link

@h-joo h-joo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dragomirtitian dragomirtitian merged commit 35ccc67 into isolated-declarations Nov 14, 2023
1 check passed
@dragomirtitian dragomirtitian deleted the isolated-declarations-evaluator branch November 17, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-joo h-joo h-joo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragomirtitian @h-joo