Isolated declarations refactor #115
Conversation
dragomirtitian
force-pushed
the
isolated-declarations-refactor
branch
from
9ac5c52
to
1b9efcd
Compare
| @@ -366,6 +415,9 @@ export function transformDeclarations(context: TransformationContext) { | |||
| } | |||
|
|
|||
| function trackReferencedAmbientModule(node: ModuleDeclaration, symbol: Symbol) { | |||
| // We forbid references in isolated declarations no need to report any errors on them | |||
| if (isolatedDeclarations) return; | |||
There was a problem hiding this comment.
I wonder if some of these early returns should/could be assertions or debug failures. That might make it easier to find errors?
E.g. here it looks like trackReferencedAmbientModule is only called in trackReferencedAmbientModuleFromImport and in checker.ts. The checker tests if the function exists first. Could make it an assertion here, remove the function from the tracker and add either assertion or early return in trackReferencedAmbientModuleFromImport.
All of this could be wrong, though. I have very little context here.
There was a problem hiding this comment.
Yeah. Changed it to remove those for function in the symbol tracker.
| }, | ||
| }); | ||
| if (isolatedDeclarations) { | ||
| const symbolTracker: SymbolTracker = { |
There was a problem hiding this comment.
Can you move this out of the if statement and assign the specific case to make it more readable the difference?
i.e symbolTracker.moduleResolverHost = host;
There was a problem hiding this comment.
I changed a bit to move the symbol tracker creation to a single location. And not create it in isolated declaration mode.
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
dragomirtitian
force-pushed
the
isolated-declarations-refactor
branch
from
1b9efcd
to
96c9c15
Compare
No description provided.