Isolated declarations enums #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirtitian
force-pushed
the
isolated-declarations-enums
branch
2 times, most recently
from
8cc09a1
to
3403de2
Compare
h-joo
approved these changes
Nov 27, 2023
| @@ -122,13 +118,39 @@ export function createEmitDeclarationResolver(file: SourceFile): IsolatedEmitRes | |||
| } | |||
| return undefined; | |||
| } | |||
|
|
|||
| function resolveEntityName(location: Node, node: Expression, meaning: SymbolFlags): EmitDeclarationSymbol | undefined { | |||
There was a problem hiding this comment.
Shouldn't this be resolveEntityName(location: EnumDeclaration, ... ?
And on the same point, I feel using a specific name for the variable would make more sense (e.g. enumDecl).
There was a problem hiding this comment.
This will actually be moved in #120 and be used in the more generic sense of resolving any entity name in any location.
| return undefined; | ||
| } | ||
| } | ||
| function isTargetEnumDeclaration(target: Expression, location: EnumDeclaration) { |
There was a problem hiding this comment.
Nit: Technically you're checking whether the target expression is an enum member, not a declaration.
There was a problem hiding this comment.
isExpressionMemberOfEnum is more descriptive I think
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
dragomirtitian
force-pushed
the
isolated-declarations-enums
branch
from
3403de2
to
da557b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.