TSC in isolated declaration will still use the type checker to print types #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
dragomirtitian
force-pushed
the
isolated-declarations-use-tsc-resolver
branch
from
3da49c4
to
fb08ff8
Compare
h-joo
approved these changes
Dec 5, 2023
...rence/isolated-declarations/auto-fixed/diff/declarationEmitObjectLiteralAccessors1.d.ts.diff
Outdated
Show resolved
Hide resolved
...ce/isolated-declarations/original/diff/mappedTypeWithAsClauseAndLateBoundProperty2.d.ts.diff
Outdated
Show resolved
Hide resolved
| currentExportsSymbolTable = exports; | ||
| if (isBlockScopedContainerTopLevel(scope)) { |
There was a problem hiding this comment.
Can you explain a bit what the effect of this and related code separating a function local table? I don't think I fully understand the flow of what changed here.
There was a problem hiding this comment.
Initially we didn't go into blocks however I recently found that TS will add expando members from nested blocks. Ex:
function Foo() {}
if(Math.random()) { Foo.test = 1; }
{ Foo. bar =2; }This means that we now do care about variables defined in blocks and the fact that they are only scoped to that block since that means any member accesses in that block will not add expando members to any variable that is shadowed in that scope:
function Foo() {}
if(Math.random()) { Foo.test = 1; }
{ let Foo: any = {}; Foo. bar =2; } // bar not on Foo(TS also handled this incorrectly until recently: microsoft#56538)
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
dragomirtitian
force-pushed
the
isolated-declarations-use-tsc-resolver
branch
from
bb439ac
to
2c0bf81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revealed some differences between TSC and DTE type printing.