Reduce false positive reports of IsolatedDeclarations errors #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and typeLiteralNodes. As this will automatically be inferred as 'any' when noImplicitAny is off, and will be it's own error when noImplicitAny is on. Signed-off-by: Hana Joo <hanajoo@google.com>
do not report cases where it's an own compiler error. Signed-off-by: Hana Joo <hanajoo@google.com>
can report errors in non-sensical places such as ill-formed AST where it still succeeds to parse, but the fixer would not be able to find a proper node to annotate types. Signed-off-by: Hana Joo <hanajoo@google.com>
h-joo
force-pushed
the
betterDiagnostics
branch
from
72042b8
to
9942551
Compare
dragomirtitian
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and make the code-fixer more resilient in places where the isolatedDeclaration error is still reported in insesensible locations.