Isolated declarations improvements to triple slash directives and imports. #94
Conversation
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
…invalid code. Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
dragomirtitian
force-pushed
the
isolated-declarations-improvements
branch
2 times, most recently
from
cf61980
to
99ce432
Compare
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
…fied with the codemod Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
dragomirtitian
force-pushed
the
isolated-declarations-improvements
branch
from
99ce432
to
e772096
Compare
| newLine: settings.newLine, | ||
| target: settings.target, | ||
| removeComments: false, | ||
| omitTrailingSemicolon: true, |
There was a problem hiding this comment.
It created some print differences with original tests
| @@ -54,7 +54,7 @@ function findNearestParentWithTypeAnnotation(node: ts.Node): ts.Node | undefined | |||
| export function addTypeAnnotationTransformer(sourceFile: ts.SourceFile, program: ts.Program, moduleResolutionHost?: ts.ModuleResolutionHost) { | |||
| const typeChecker = program.getTypeChecker(); | |||
| const nodesToFix = new Map(program.getDeclarationDiagnostics(sourceFile). | |||
| filter((diag) => diag.code === 9007). | |||
| filter((diag) => diag.code === 9007 || diag.code === 9009). | |||
There was a problem hiding this comment.
I'm guessing I should write a fix for the new error code 9009 by adding declarations to property assignments happening in functions?
There was a problem hiding this comment.
My intention is to use the new error code for both function declarations and expressions. But yes, it would be helpful to treat the error for expando function declarations.
| if(node.initializer && localType && strictNullChecks && !resolver.isOptionalParameter(node)) { | ||
| localType.typeNode = addUndefinedInUnion(localType.typeNode); | ||
| else { | ||
| localType = invalid(node); |
There was a problem hiding this comment.
Can you clarify what this chunk of changes imply? I don't think I understood.
There was a problem hiding this comment.
I initially wanted to support types parameters that are not annotated (ok under noImplicitAny: false). Turns out that has several complications so I decided to revert the support for those.
No description provided.