Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #45: Implement is_noexcept meta function #56

Merged
merged 15 commits into from
Jul 1, 2024

Conversation

delimbetov
Copy link

@delimbetov delimbetov commented Jun 7, 2024

Issue number of the reported bug or feature request: #45

Describe your changes
Added is_noexcept as per P2996r5 spec.
The function checks for noexcept on:

  1. (virtual) Method and it's type
  2. Template method instantiation and it's type
  3. Function and it's type
  4. Function template instantiation and it's type

For everything else it returns false.

Testing performed
Tests added to libcxx to cover all supported scenarios.

libcxx/include/experimental/meta Outdated Show resolved Hide resolved
clang/lib/Sema/Metafunctions.cpp Outdated Show resolved Hide resolved
@delimbetov delimbetov requested a review from katzdm June 13, 2024 21:13
@katzdm
Copy link
Collaborator

katzdm commented Jun 29, 2024

Hey @delimbetov - We got feedback from LEWG this week to reduce the scope of this function. Please see the latest spec here, and modify accordingly. Looking forward to taking another look thereafter; let me know.

@delimbetov
Copy link
Author

Hey @delimbetov - We got feedback from LEWG this week to reduce the scope of this function. Please see the latest spec here, and modify accordingly. Looking forward to taking another look thereafter; let me know.

Updated @katzdm

@katzdm katzdm merged commit cbc95f8 into bloomberg:p2996 Jul 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants